Tuesday, May 30, 2017

Episode 66: Code Reviews

Download

We are sponsored by audible! http://www.audibletrial.com/programmingthrowdown

We are on Patreon! https://www.patreon.com/programmingthrowdown

T-Shirts! http://www.cafepress.com/programmingthrowdown/13590693

Intro Topic: 3-D Printing http://www.gearbest.com/3d-printers-3d-printer-kits/pp_337314.html

News/Links


Book of the Show


Tool of the Show


Code Reviews

  • Why?
    • Get another pair of eyes
    • Teach others about what you do
  • What Not to do
    • Become a road block to work
    • Let reviews linger
    • Let it become about only style
    • Have only some people do reviews
  • How?
    • Email
    • In-person
    • Web tools
      • Phabricator
      • Gerrit
      • Gitlab/github
  • Rules
    • All changes must be approved by someone
    • Readability
    • +1 vs +2 or similar
    • To push anyways, there's an emergency mode
    • Keep line count down